lkml.org 
[lkml]   [2020]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.19 018/264] chelsio/chtls: correct function return and return type
Hi!

> From: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
>
> [ Upstream commit 8580a61aede28d441e1c80588803411ee86aa299 ]
>
> csk_mem_free() should return true if send buffer is available,
> false otherwise.

> Fixes: 3b8305f5c844 ("crypto: chtls - wait for memory sendmsg, sendpage")

This does not fix anything. In fact, binary code should be exactly
equivalent. It does not need to be in 4.19-stable.

Best regards,
Pavel


> --- a/drivers/crypto/chelsio/chtls/chtls_io.c
> +++ b/drivers/crypto/chelsio/chtls/chtls_io.c
> @@ -914,9 +914,9 @@ static int tls_header_read(struct tls_hd
> return (__force int)cpu_to_be16(thdr->length);
> }
>
> -static int csk_mem_free(struct chtls_dev *cdev, struct sock *sk)
> +static bool csk_mem_free(struct chtls_dev *cdev, struct sock *sk)
> {
> - return (cdev->max_host_sndbuf - sk->sk_wmem_queued);
> + return (cdev->max_host_sndbuf - sk->sk_wmem_queued > 0);
> }
>
> static int csk_wait_memory(struct chtls_dev *cdev,
>

--
http://www.livejournal.com/~pavelmachek
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-10-28 23:18    [W:0.667 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site