lkml.org 
[lkml]   [2020]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] mm/slub: fix panic in slab_alloc_node()
From
Date
Le 28/10/2020 à 12:11, Christopher Lameter a écrit :
> On Tue, 27 Oct 2020, Laurent Dufour wrote:
>
>> The issue is that object is not NULL while page is NULL which is odd but
>> may happen if the cache flush happened after loading object but before
>> loading page. Thus checking for the page pointer is required too.
>
>
> Ok then lets revert commit 6159d0f5c03e? The situation may occur
> elsewhere too.

The only other call to node_match() is in ___slab_alloc(), and the page pointer
is already checked there.
So there is no real need to check it in node_match().

\
 
 \ /
  Last update: 2020-10-28 23:01    [W:0.315 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site