lkml.org 
[lkml]   [2020]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4.19 111/264] nvmem: core: fix possibly memleak when use nvmem_cell_info_to_nvmem_cell()
    On Wed, Oct 28, 2020 at 09:12:34PM +0100, Pavel Machek wrote:
    >Hi!
    >
    >> From: Vadym Kochan <vadym.kochan@plvision.eu>
    >>
    >> [ Upstream commit fc9eec4d643597cf4cb2fef17d48110e677610da ]
    >>
    >> Fix missing 'kfree_const(cell->name)' when call to
    >> nvmem_cell_info_to_nvmem_cell() in several places:
    >>
    >> * after nvmem_cell_info_to_nvmem_cell() failed during
    >> nvmem_add_cells()
    >>
    >> * during nvmem_device_cell_{read,write} when cell->name is
    >> kstrdup'ed() without calling kfree_const() at the end, but
    >> really there is no reason to do that 'dup, because the cell
    >> instance is allocated on the stack for some short period to be
    >> read/write without exposing it to the caller.
    >>
    >> So the new nvmem_cell_info_to_nvmem_cell_nodup() helper is introduced
    >> which is used to convert cell_info -> cell without name duplication as
    >> a lighweight version of nvmem_cell_info_to_nvmem_cell().
    >>
    >> Fixes: e2a5402ec7c6 ("nvmem: Add nvmem_device based consumer apis.")
    >
    >There's something very wrong here.

    Right, looks like it actually fixes 16bb7abc4a6b ("nvmem: core: fix
    memory abort in cleanup path"). I'll just drop this commit.

    --
    Thanks,
    Sasha

    \
     
     \ /
      Last update: 2020-10-29 02:05    [W:3.907 / U:0.524 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site