lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 088/139] memory: fsl-corenet-cf: Fix handling of platform_get_irq() error
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit dd85345abca60a8916617e8d75c0f9ce334336dd ]

    platform_get_irq() returns -ERRNO on error. In such case comparison
    to 0 would pass the check.

    Fixes: 54afbec0d57f ("memory: Freescale CoreNet Coherency Fabric error reporting driver")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Link: https://lore.kernel.org/r/20200827073315.29351-1-krzk@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/memory/fsl-corenet-cf.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/memory/fsl-corenet-cf.c b/drivers/memory/fsl-corenet-cf.c
    index 662d050243bec..2fbf8d09af36b 100644
    --- a/drivers/memory/fsl-corenet-cf.c
    +++ b/drivers/memory/fsl-corenet-cf.c
    @@ -215,10 +215,8 @@ static int ccf_probe(struct platform_device *pdev)
    dev_set_drvdata(&pdev->dev, ccf);

    irq = platform_get_irq(pdev, 0);
    - if (!irq) {
    - dev_err(&pdev->dev, "%s: no irq\n", __func__);
    - return -ENXIO;
    - }
    + if (irq < 0)
    + return irq;

    ret = devm_request_irq(&pdev->dev, irq, ccf_irq, 0, pdev->name, ccf);
    if (ret) {
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 15:12    [W:2.546 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site