lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 075/139] lib/crc32.c: fix trivial typo in preprocessor condition
    Date
    From: Tobias Jordan <kernel@cdqe.de>

    [ Upstream commit 904542dc56524f921a6bab0639ff6249c01e775f ]

    Whether crc32_be needs a lookup table is chosen based on CRC_LE_BITS.
    Obviously, the _be function should be governed by the _BE_ define.

    This probably never pops up as it's hard to come up with a configuration
    where CRC_BE_BITS isn't the same as CRC_LE_BITS and as nobody is using
    bitwise CRC anyway.

    Fixes: 46c5801eaf86 ("crc32: bolt on crc32c")
    Signed-off-by: Tobias Jordan <kernel@cdqe.de>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Cc: Krzysztof Kozlowski <krzk@kernel.org>
    Cc: Jonathan Corbet <corbet@lwn.net>
    Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Link: https://lkml.kernel.org/r/20200923182122.GA3338@agrajag.zerfleddert.de
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    lib/crc32.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/lib/crc32.c b/lib/crc32.c
    index 7fbd1a112b9d2..0d450462b0bd5 100644
    --- a/lib/crc32.c
    +++ b/lib/crc32.c
    @@ -327,7 +327,7 @@ static inline u32 __pure crc32_be_generic(u32 crc, unsigned char const *p,
    return crc;
    }

    -#if CRC_LE_BITS == 1
    +#if CRC_BE_BITS == 1
    u32 __pure crc32_be(u32 crc, unsigned char const *p, size_t len)
    {
    return crc32_be_generic(crc, p, len, NULL, CRCPOLY_BE);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 15:05    [W:4.098 / U:24.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site