lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] seq_file: fix clang warning for NULL pointer arithmetic
> index f277d023ebcd..b55e6ef4d677 100644
> --- a/fs/kernfs/file.c
> +++ b/fs/kernfs/file.c
> @@ -124,7 +124,7 @@ static void *kernfs_seq_start(struct seq_file *sf, loff_t *ppos)
> * The same behavior and code as single_open(). Returns
> * !NULL if pos is at the beginning; otherwise, NULL.
> */
> - return NULL + !*ppos;
> + return (void *)(uintptr_t)!*ppos;

Yikes. This is just horrible, why bnot the completely obvious:

if (ops->seq_start) {
...
return next;
}

if (*ppos)
return NULL;
return ppos; /* random cookie */

> static void *single_start(struct seq_file *p, loff_t *pos)
> {
> - return NULL + (*pos == 0);
> + return (void *)(uintptr_t)(*pos == 0);

Same here.

\
 
 \ /
  Last update: 2020-10-27 11:46    [W:0.058 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site