lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 014/139] crypto: algif_aead - Do not set MAY_BACKLOG on the async path
    Date
    From: Herbert Xu <herbert@gondor.apana.org.au>

    commit cbdad1f246dd98e6c9c32a6e5212337f542aa7e0 upstream.

    The async path cannot use MAY_BACKLOG because it is not meant to
    block, which is what MAY_BACKLOG does. On the other hand, both
    the sync and async paths can make use of MAY_SLEEP.

    Fixes: 83094e5e9e49 ("crypto: af_alg - add async support to...")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    crypto/algif_aead.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/crypto/algif_aead.c
    +++ b/crypto/algif_aead.c
    @@ -455,7 +455,7 @@ static int aead_recvmsg_async(struct soc
    memcpy(areq->iv, ctx->iv, crypto_aead_ivsize(tfm));
    aead_request_set_tfm(req, tfm);
    aead_request_set_ad(req, ctx->aead_assoclen);
    - aead_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG,
    + aead_request_set_callback(req, CRYPTO_TFM_REQ_MAY_SLEEP,
    aead_async_cb, req);
    used -= ctx->aead_assoclen;

    @@ -925,7 +925,7 @@ static int aead_accept_parent_nokey(void
    ask->private = ctx;

    aead_request_set_tfm(&ctx->aead_req, aead);
    - aead_request_set_callback(&ctx->aead_req, CRYPTO_TFM_REQ_MAY_BACKLOG,
    + aead_request_set_callback(&ctx->aead_req, CRYPTO_TFM_REQ_MAY_SLEEP,
    af_alg_complete, &ctx->completion);

    sk->sk_destruct = aead_sock_destruct;

    \
     
     \ /
      Last update: 2020-10-27 19:23    [W:4.421 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site