lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 079/264] scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba()
    Date
    From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

    [ Upstream commit ca4fb89a3d714a770e9c73c649da830f3f4a5326 ]

    On an error exit path, a negative error code should be returned instead of
    a positive return value.

    Link: https://lore.kernel.org/r/20200802111530.5020-1-tianjia.zhang@linux.alibaba.com
    Fixes: 8777e4314d39 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine")
    Cc: Quinn Tran <quinn.tran@cavium.com>
    Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
    index 3e2f8ce1d9a97..7821c1695e824 100644
    --- a/drivers/scsi/qla2xxx/qla_nvme.c
    +++ b/drivers/scsi/qla2xxx/qla_nvme.c
    @@ -676,7 +676,7 @@ int qla_nvme_register_hba(struct scsi_qla_host *vha)
    struct nvme_fc_port_template *tmpl;
    struct qla_hw_data *ha;
    struct nvme_fc_port_info pinfo;
    - int ret = EINVAL;
    + int ret = -EINVAL;

    if (!IS_ENABLED(CONFIG_NVME_FC))
    return ret;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 18:58    [W:4.028 / U:0.508 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site