lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 057/408] EDAC/ti: Fix handling of platform_get_irq() error
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit 66077adb70a2a9e92540155b2ace33ec98299c90 ]

    platform_get_irq() returns a negative error number on error. In such a
    case, comparison to 0 would pass the check therefore check the return
    value properly, whether it is negative.

    [ bp: Massage commit message. ]

    Fixes: 86a18ee21e5e ("EDAC, ti: Add support for TI keystone and DRA7xx EDAC")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Borislav Petkov <bp@suse.de>
    Reviewed-by: Tero Kristo <t-kristo@ti.com>
    Link: https://lkml.kernel.org/r/20200827070743.26628-2-krzk@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/edac/ti_edac.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c
    index 6ac26d1b929f0..3247689467435 100644
    --- a/drivers/edac/ti_edac.c
    +++ b/drivers/edac/ti_edac.c
    @@ -278,7 +278,8 @@ static int ti_edac_probe(struct platform_device *pdev)

    /* add EMIF ECC error handler */
    error_irq = platform_get_irq(pdev, 0);
    - if (!error_irq) {
    + if (error_irq < 0) {
    + ret = error_irq;
    edac_printk(KERN_ERR, EDAC_MOD_NAME,
    "EMIF irq number not defined.\n");
    goto err;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 18:47    [W:2.237 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site