lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 054/633] net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action()
    Date
    From: Guillaume Nault <gnault@redhat.com>

    [ Upstream commit b130762161374b1ef31549bef8ebd4abeb998d94 ]

    We need to jump to the "err_out_locked" label when
    tcf_gate_get_entries() fails. Otherwise, tc_setup_flow_action() exits
    with ->tcfa_lock still held.

    Fixes: d29bdd69ecdd ("net: schedule: add action gate offloading")
    Signed-off-by: Guillaume Nault <gnault@redhat.com>
    Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
    Link: https://lore.kernel.org/r/12f60e385584c52c22863701c0185e40ab08a7a7.1603207948.git.gnault@redhat.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/sched/cls_api.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/sched/cls_api.c
    +++ b/net/sched/cls_api.c
    @@ -3707,7 +3707,7 @@ int tc_setup_flow_action(struct flow_act
    entry->gate.num_entries = tcf_gate_num_entries(act);
    err = tcf_gate_get_entries(entry, act);
    if (err)
    - goto err_out;
    + goto err_out_locked;
    } else {
    err = -EOPNOTSUPP;
    goto err_out_locked;

    \
     
     \ /
      Last update: 2020-10-27 18:27    [W:2.312 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site