lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 539/633] media: exynos4-is: Fix a reference count leak
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit 64157b2cb1940449e7df2670e85781c690266588 ]

    pm_runtime_get_sync() increments the runtime PM usage counter even
    when it returns an error code, causing incorrect ref count if
    pm_runtime_put_noidle() is not called in error handling paths.
    Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.

    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/exynos4-is/mipi-csis.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c b/drivers/media/platform/exynos4-is/mipi-csis.c
    index 540151bbf58f2..1aac167abb175 100644
    --- a/drivers/media/platform/exynos4-is/mipi-csis.c
    +++ b/drivers/media/platform/exynos4-is/mipi-csis.c
    @@ -510,8 +510,10 @@ static int s5pcsis_s_stream(struct v4l2_subdev *sd, int enable)
    if (enable) {
    s5pcsis_clear_counters(state);
    ret = pm_runtime_get_sync(&state->pdev->dev);
    - if (ret && ret != 1)
    + if (ret && ret != 1) {
    + pm_runtime_put_noidle(&state->pdev->dev);
    return ret;
    + }
    }

    mutex_lock(&state->lock);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:54    [W:2.088 / U:1.744 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site