lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 607/757] arm64: dts: qcom: msm8916: Fix MDP/DSI interrupts
    Date
    From: Stephan Gerhold <stephan@gerhold.net>

    [ Upstream commit 027cca9eb5b450c3f6bb916ba999144c2ec23cb7 ]

    The mdss node sets #interrupt-cells = <1>, so its interrupts
    should be referenced using a single cell (in this case: only the
    interrupt number).

    However, right now the mdp/dsi node both have two interrupt cells
    set, e.g. interrupts = <4 0>. The 0 is probably meant to say
    IRQ_TYPE_NONE (= 0), but with #interrupt-cells = <1> this is
    actually interpreted as a second interrupt line.

    Remove the IRQ flags from both interrupts to fix this.

    Fixes: 305410ffd1b2 ("arm64: dts: msm8916: Add display support")
    Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
    Link: https://lore.kernel.org/r/20200915071221.72895-5-stephan@gerhold.net
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
    index c2fb9f7291c5e..75687442d5827 100644
    --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
    +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
    @@ -1052,7 +1052,7 @@ mdp: mdp@1a01000 {
    reg-names = "mdp_phys";

    interrupt-parent = <&mdss>;
    - interrupts = <0 0>;
    + interrupts = <0>;

    clocks = <&gcc GCC_MDSS_AHB_CLK>,
    <&gcc GCC_MDSS_AXI_CLK>,
    @@ -1084,7 +1084,7 @@ dsi0: dsi@1a98000 {
    reg-names = "dsi_ctrl";

    interrupt-parent = <&mdss>;
    - interrupts = <4 0>;
    + interrupts = <4>;

    assigned-clocks = <&gcc BYTE0_CLK_SRC>,
    <&gcc PCLK0_CLK_SRC>;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:40    [W:4.780 / U:0.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site