lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 608/757] soc: qcom: apr: Fixup the error displayed on lookup failure
    Date
    From: Sibi Sankar <sibis@codeaurora.org>

    [ Upstream commit ba34f977c333f96c8acd37ec30e232220399f5a5 ]

    APR client incorrectly prints out "ret" variable on pdr_add_lookup failure,
    it should be printing the error value returned by the lookup instead.

    Fixes: 8347356626028 ("soc: qcom: apr: Add avs/audio tracking functionality")
    Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
    Link: https://lore.kernel.org/r/20200915154232.27523-1-sibis@codeaurora.org
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/qcom/apr.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c
    index 1f35b097c6356..7abfc8c4fdc72 100644
    --- a/drivers/soc/qcom/apr.c
    +++ b/drivers/soc/qcom/apr.c
    @@ -328,7 +328,7 @@ static int of_apr_add_pd_lookups(struct device *dev)

    pds = pdr_add_lookup(apr->pdr, service_name, service_path);
    if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) {
    - dev_err(dev, "pdr add lookup failed: %d\n", ret);
    + dev_err(dev, "pdr add lookup failed: %ld\n", PTR_ERR(pds));
    return PTR_ERR(pds);
    }
    }
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:35    [W:4.083 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site