lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 292/757] ASoC: tas2770: Fix calling reset in probe
    Date
    From: Dan Murphy <dmurphy@ti.com>

    [ Upstream commit b0bcbe615756d5923eec4e95996e4041627e5741 ]

    tas2770_reset is called during i2c probe. The reset calls the
    snd_soc_component_write which depends on the tas2770->component being
    available. The component pointer is not set until codec_probe so move
    the reset to the codec_probe after the pointer is set.

    Fixes: 1a476abc723e6 ("tas2770: add tas2770 smart PA kernel driver")
    Signed-off-by: Dan Murphy <dmurphy@ti.com>
    Link: https://lore.kernel.org/r/20200918190548.12598-1-dmurphy@ti.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/tas2770.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c
    index c098518343959..03d7ad1885b81 100644
    --- a/sound/soc/codecs/tas2770.c
    +++ b/sound/soc/codecs/tas2770.c
    @@ -575,6 +575,8 @@ static int tas2770_codec_probe(struct snd_soc_component *component)

    tas2770->component = component;

    + tas2770_reset(tas2770);
    +
    return 0;
    }

    @@ -771,8 +773,6 @@ static int tas2770_i2c_probe(struct i2c_client *client,
    tas2770->channel_size = 0;
    tas2770->slot_width = 0;

    - tas2770_reset(tas2770);
    -
    result = tas2770_register_codec(tas2770);
    if (result)
    dev_err(tas2770->dev, "Register codec failed.\n");
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:11    [W:4.224 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site