lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 376/757] ipmi_si: Fix wrong return value in try_smi_init()
    Date
    From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

    [ Upstream commit 8fe7990ceda8597e407d06bffc4bdbe835a93ece ]

    On an error exit path, a negative error code should be returned
    instead of a positive return value.

    Fixes: 90b2d4f15ff7 ("ipmi_si: Remove hacks for adding a dummy platform devices")
    Cc: Corey Minyard <cminyard@mvista.com>
    Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
    Message-Id: <20201005145212.84435-1-tianjia.zhang@linux.alibaba.com>
    Signed-off-by: Corey Minyard <cminyard@mvista.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/char/ipmi/ipmi_si_intf.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
    index 77b8d551ae7fe..dd559661c15b3 100644
    --- a/drivers/char/ipmi/ipmi_si_intf.c
    +++ b/drivers/char/ipmi/ipmi_si_intf.c
    @@ -1963,7 +1963,7 @@ static int try_smi_init(struct smi_info *new_smi)
    /* Do this early so it's available for logs. */
    if (!new_smi->io.dev) {
    pr_err("IPMI interface added with no device\n");
    - rv = EIO;
    + rv = -EIO;
    goto out_err;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:10    [W:2.578 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site