lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 538/633] media: exynos4-is: Fix a reference count leak due to pm_runtime_get_sync
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit c47f7c779ef0458a58583f00c9ed71b7f5a4d0a2 ]

    On calling pm_runtime_get_sync() the reference count of the device
    is incremented. In case of failure, decrement the
    reference count before returning the error.

    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/exynos4-is/media-dev.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c
    index 2f90607c3797d..a07d796f63df0 100644
    --- a/drivers/media/platform/exynos4-is/media-dev.c
    +++ b/drivers/media/platform/exynos4-is/media-dev.c
    @@ -484,8 +484,10 @@ static int fimc_md_register_sensor_entities(struct fimc_md *fmd)
    return -ENXIO;

    ret = pm_runtime_get_sync(fmd->pmf);
    - if (ret < 0)
    + if (ret < 0) {
    + pm_runtime_put(fmd->pmf);
    return ret;
    + }

    fmd->num_sensors = 0;

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:40    [W:2.820 / U:0.564 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site