lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 131/757] media: m5mols: Check function pointer in m5mols_sensor_power
    Date
    From: Tom Rix <trix@redhat.com>

    [ Upstream commit 52438c4463ac904d14bf3496765e67750766f3a6 ]

    clang static analysis reports this error

    m5mols_core.c:767:4: warning: Called function pointer
    is null (null dereference) [core.CallAndMessage]
    info->set_power(&client->dev, 0);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    In other places, the set_power ptr is checked.
    So add a check.

    Fixes: bc125106f8af ("[media] Add support for M-5MOLS 8 Mega Pixel camera ISP")
    Signed-off-by: Tom Rix <trix@redhat.com>
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/m5mols/m5mols_core.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/media/i2c/m5mols/m5mols_core.c b/drivers/media/i2c/m5mols/m5mols_core.c
    index de295114ca482..21666d705e372 100644
    --- a/drivers/media/i2c/m5mols/m5mols_core.c
    +++ b/drivers/media/i2c/m5mols/m5mols_core.c
    @@ -764,7 +764,8 @@ static int m5mols_sensor_power(struct m5mols_info *info, bool enable)

    ret = regulator_bulk_enable(ARRAY_SIZE(supplies), supplies);
    if (ret) {
    - info->set_power(&client->dev, 0);
    + if (info->set_power)
    + info->set_power(&client->dev, 0);
    return ret;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:40    [W:2.619 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site