lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 172/757] media: ti-vpe: Fix a missing check and reference count leak
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit 7dae2aaaf432767ca7aa11fa84643a7c2600dbdd ]

    pm_runtime_get_sync() increments the runtime PM usage counter even
    when it returns an error code, causing incorrect ref count if
    pm_runtime_put_noidle() is not called in error handling paths.
    And also, when the call of function vpe_runtime_get() failed,
    we won't call vpe_runtime_put().
    Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails
    inside vpe_runtime_get().

    Fixes: 4571912743ac ("[media] v4l: ti-vpe: Add VPE mem to mem driver")
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/ti-vpe/vpe.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c
    index 346f8212791cf..779dd74b82d01 100644
    --- a/drivers/media/platform/ti-vpe/vpe.c
    +++ b/drivers/media/platform/ti-vpe/vpe.c
    @@ -2475,6 +2475,8 @@ static int vpe_runtime_get(struct platform_device *pdev)

    r = pm_runtime_get_sync(&pdev->dev);
    WARN_ON(r < 0);
    + if (r)
    + pm_runtime_put_noidle(&pdev->dev);
    return r < 0 ? r : 0;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:30    [W:2.923 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site