lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 170/757] media: s5p-mfc: Fix a reference count leak
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit 78741ce98c2e36188e2343434406b0e0bc50b0e7 ]

    pm_runtime_get_sync() increments the runtime PM usage counter even
    when it returns an error code, causing incorrect ref count if
    pm_runtime_put_noidle() is not called in error handling paths.
    Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.

    Fixes: c5086f130a77 ("[media] s5p-mfc: Use clock gating only on MFC v5 hardware")
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/s5p-mfc/s5p_mfc_pm.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c b/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c
    index 7d52431c2c837..62d2320a72186 100644
    --- a/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c
    +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c
    @@ -79,8 +79,10 @@ int s5p_mfc_power_on(void)
    int i, ret = 0;

    ret = pm_runtime_get_sync(pm->device);
    - if (ret < 0)
    + if (ret < 0) {
    + pm_runtime_put_noidle(pm->device);
    return ret;
    + }

    /* clock control */
    for (i = 0; i < pm->num_clocks; i++) {
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:30    [W:4.096 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site