lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 468/633] Input: stmfts - fix a & vs && typo
    Date
    From: YueHaibing <yuehaibing@huawei.com>

    [ Upstream commit d04afe14b23651e7a8bc89727a759e982a8458e4 ]

    In stmfts_sysfs_hover_enable_write(), we should check value and
    sdata->hover_enabled is all true.

    Fixes: 78bcac7b2ae1 ("Input: add support for the STMicroelectronics FingerTip touchscreen")
    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Link: https://lore.kernel.org/r/20200916141941.16684-1-yuehaibing@huawei.com
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/input/touchscreen/stmfts.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
    index b54cc64e4ea64..389356332c54a 100644
    --- a/drivers/input/touchscreen/stmfts.c
    +++ b/drivers/input/touchscreen/stmfts.c
    @@ -479,7 +479,7 @@ static ssize_t stmfts_sysfs_hover_enable_write(struct device *dev,

    mutex_lock(&sdata->mutex);

    - if (value & sdata->hover_enabled)
    + if (value && sdata->hover_enabled)
    goto out;

    if (sdata->running)
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:17    [W:2.421 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site