lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 097/633] x86/events/amd/iommu: Fix sizeof mismatch
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit 59d5396a4666195f89a67e118e9e627ddd6f53a1 ]

    An incorrect sizeof is being used, struct attribute ** is not correct,
    it should be struct attribute *. Note that since ** is the same size as
    * this is not causing any issues. Improve this fix by using sizeof(*attrs)
    as this allows us to not even reference the type of the pointer.

    Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)")
    Fixes: 51686546304f ("x86/events/amd/iommu: Fix sysfs perf attribute groups")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Link: https://lkml.kernel.org/r/20201001113900.58889-1-colin.king@canonical.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/x86/events/amd/iommu.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c
    index fb616203ce427..be50ef8572cce 100644
    --- a/arch/x86/events/amd/iommu.c
    +++ b/arch/x86/events/amd/iommu.c
    @@ -379,7 +379,7 @@ static __init int _init_events_attrs(void)
    while (amd_iommu_v2_event_descs[i].attr.attr.name)
    i++;

    - attrs = kcalloc(i + 1, sizeof(struct attribute **), GFP_KERNEL);
    + attrs = kcalloc(i + 1, sizeof(*attrs), GFP_KERNEL);
    if (!attrs)
    return -ENOMEM;

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:10    [W:3.298 / U:0.748 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site