lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 394/408] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach
    Date
    From: Wang Yufen <wangyufen@huawei.com>

    [ Upstream commit 6c151410d5b57e6bb0d91a735ac511459539a7bf ]

    When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL,
    we should destroy the workqueue.

    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Wang Yufen <wangyufen@huawei.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/1595237765-66238-1-git-send-email-wangyufen@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
    index e3dd8623be4ec..c2705d7a4247e 100644
    --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
    +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
    @@ -1619,6 +1619,8 @@ int brcmf_proto_msgbuf_attach(struct brcmf_pub *drvr)
    BRCMF_TX_IOCTL_MAX_MSG_SIZE,
    msgbuf->ioctbuf,
    msgbuf->ioctbuf_handle);
    + if (msgbuf->txflow_wq)
    + destroy_workqueue(msgbuf->txflow_wq);
    kfree(msgbuf);
    }
    return -ENOMEM;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 16:10    [W:3.238 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site