lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 235/408] perf stat: Skip duration_time in setup_system_wide
    Date
    From: Jin Yao <yao.jin@linux.intel.com>

    [ Upstream commit 002a3d690f95804bdef6b70b26154103518e13d9 ]

    Some metrics (such as DRAM_BW_Use) consists of uncore events and
    duration_time. For uncore events, counter->core.system_wide is true. But
    for duration_time, counter->core.system_wide is false so
    target.system_wide is set to false.

    Then 'enable_on_exec' is set in perf_event_attr of uncore event. Kernel
    will return error when trying to open the uncore event.

    This patch skips the duration_time in setup_system_wide then
    target.system_wide will be set to true for the evlist of uncore events +
    duration_time.

    Before (tested on skylake desktop):

    # perf stat -M DRAM_BW_Use -- sleep 1
    Error:
    The sys_perf_event_open() syscall returned with 22 (Invalid argument) for event (arb/event=0x84,umask=0x1/).
    /bin/dmesg | grep -i perf may provide additional information.

    After:

    # perf stat -M DRAM_BW_Use -- sleep 1

    Performance counter stats for 'system wide':

    169 arb/event=0x84,umask=0x1/ # 0.00 DRAM_BW_Use
    40,427 arb/event=0x81,umask=0x1/
    1,000,902,197 ns duration_time

    1.000902197 seconds time elapsed

    Fixes: e3ba76deef23064f ("perf tools: Force uncore events to system wide monitoring")
    Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
    Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Jin Yao <yao.jin@intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lore.kernel.org/lkml/20200922015004.30114-1-yao.jin@linux.intel.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/perf/builtin-stat.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
    index ac2feddc75fdd..ea183922c4ef1 100644
    --- a/tools/perf/builtin-stat.c
    +++ b/tools/perf/builtin-stat.c
    @@ -1671,8 +1671,10 @@ static void setup_system_wide(int forks)
    struct evsel *counter;

    evlist__for_each_entry(evsel_list, counter) {
    - if (!counter->core.system_wide)
    + if (!counter->core.system_wide &&
    + strcmp(counter->name, "duration_time")) {
    return;
    + }
    }

    if (evsel_list->core.nr_entries)
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 15:39    [W:3.062 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site