lkml.org 
[lkml]   [2020]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ALSA: make snd_kcontrol_new name a normal string
On Mon, 26 Oct 2020 17:52:18 +0100,
Arnd Bergmann wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> When building with W=2, there are lots of warnings about the
> snd_kcontrol_new name field being an array of 'unsigned char'
> but initialized to a string:
>
> include/sound/soc.h:93:48: warning: pointer targets in initialization of 'const unsigned char *' from 'char *' differ in signedness [-Wpointer-sign]
>
> Make it a regular 'char *' to avoid flooding the build log with this.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I'm fine to apply this, but I thought we agreed to ignore pointer
signedness intentionally? There are lots of such places and we were
fed up in the past when gcc complained a lot about those...


thanks,

Takashi

\
 
 \ /
  Last update: 2020-10-26 18:06    [W:0.074 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site