Messages in this thread | | | Subject | Re: [PATCH v6] Introduce support for Systems Management Driver over WMI for Dell Systems | From | Hans de Goede <> | Date | Mon, 26 Oct 2020 16:36:13 +0100 |
| |
Hi,
On 10/26/20 4:25 PM, Limonciello, Mario wrote: >>> + >>> + print_hex_dump_bytes("set attribute data: ", DUMP_PREFIX_NONE, buffer, >> buffer_size); >> >> This seems to be a debugging left-over? > > Yes it was for debugging, but its configurable to turn on by dynamic > debug as I can tell. Is that not correct?
Since it does not have debug in its name I sorta assumed it would always do the print. But you are right, this is a shorthand macro for print_hex_dump_debug() (which takes a few more arguments), so this only dumps the buffer when debugging is enabled.
IOW keeping this "as is" is fine, sorry for the noise.
Regards,
Has
| |