lkml.org 
[lkml]   [2020]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")
On Mon, Oct 26, 2020 at 01:33:48PM -0700, Linus Torvalds wrote:
> On Mon, Oct 26, 2020 at 12:41 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > make ARCH=um SUBARCH=x86_64 defconfig:
> >
> > Building um:defconfig ... failed
> > --------------
> > Error log:
> > arch/um/kernel/skas/clone.c:24:16: error: expected declaration specifiers or '...' before string constant
> > arch/x86/um/stub_segv.c:11:16: error: expected declaration specifiers or '...' before string constant
>
> Weird. Is __section() not defined somehow for those files?
>
> It does look like they have very minimal headers, so undoing that
> patch just for those two files is likely the right thing to do.
>
> > As with s390, reverting this patch fixes the problem.
>
> s390 should be fixed already.
>
> Is the attached minimal patch sufficient for um to get back to working
> order, or is there something else hiding there too?
>
That works for me.

Tested-by: Guenter Roeck <linux@roeck-us.net>

Thanks,
Guenter

\
 
 \ /
  Last update: 2020-10-26 22:28    [W:0.127 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site