Messages in this thread | | | Date | Sun, 25 Oct 2020 16:17:04 +0200 | From | Mike Rapoport <> | Subject | Re: [PATCH v2 1/7] mm, page_alloc: clean up pageset high and batch update |
| |
On Thu, Oct 08, 2020 at 01:41:55PM +0200, Vlastimil Babka wrote: > The updates to pcplists' high and batch valued are handled by multiple
Nit: ^ values
> functions that make the calculations hard to follow. Consolidate everything > to pageset_set_high_and_batch() and remove pageset_set_batch() and > pageset_set_high() wrappers. > > The only special case using one of the removed wrappers was: > build_all_zonelists_init() > setup_pageset() > pageset_set_batch() > which was hardcoding batch as 0, so we can just open-code a call to > pageset_update() with constant parameters instead. > > No functional change. > > Signed-off-by: Vlastimil Babka <vbabka@suse.cz> > Reviewed-by: Oscar Salvador <osalvador@suse.de> > Reviewed-by: David Hildenbrand <david@redhat.com> > Acked-by: Michal Hocko <mhocko@suse.com> > --- > mm/page_alloc.c | 49 ++++++++++++++++++++----------------------------- > 1 file changed, 20 insertions(+), 29 deletions(-)
-- Sincerely yours, Mike.
| |