Messages in this thread | | | Date | Mon, 26 Oct 2020 11:19:43 +0800 | From | Can Guo <> | Subject | Re: [PATCH v2 1/1] scsi: ufs: Fix unexpected values get from ufshcd_read_desc_param() |
| |
Hi Avri,
On 2020-10-22 14:37, Avri Altman wrote: >> Since WB feature has been added, WB related sysfs entries can be >> accessed >> even when an UFS device does not support WB feature. In that case, the >> descriptors which are not supported by the UFS device may be wrongly >> reported when they are accessed from their corrsponding sysfs entries. >> Fix it by adding a sanity check of parameter offset against the actual >> decriptor length.s > This should be a bug fix IMO, and be dealt with similarly like > ufshcd_is_wb_attrs or ufshcd_is_wb_flag. > Thanks, > Avri
Could you please elaborate on ufshcd_is_wb_attrs or ufshcd_is_wb_flag? Sorry that I don't quite get it.
Thanks,
Can Guo.
| |