lkml.org 
[lkml]   [2020]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 4/4] arch, mm: make kernel_page_present() always available
    Date
    On Sun, 2020-10-25 at 12:15 +0200, Mike Rapoport wrote:
    > index 7f248fc45317..16f878c26667 100644
    > --- a/arch/x86/mm/pat/set_memory.c
    > +++ b/arch/x86/mm/pat/set_memory.c
    > @@ -2228,7 +2228,6 @@ void __kernel_map_pages(struct page *page, int
    > numpages, int enable)
    > }
    > #endif /* CONFIG_DEBUG_PAGEALLOC */
    >
    > -#ifdef CONFIG_HIBERNATION
    > bool kernel_page_present(struct page *page)
    > {
    > unsigned int level;
    > @@ -2240,7 +2239,6 @@ bool kernel_page_present(struct page *page)
    > pte = lookup_address((unsigned long)page_address(page),
    > &level);
    > return (pte_val(*pte) & _PAGE_PRESENT);
    > }
    > -#endif /* CONFIG_HIBERNATION */

    This is only used by hibernate today right? Makes sense that it should
    return a correct answer if someone starts to use it without looking too
    closely at the header. But could we just remove the default static
    inline return true implementation and let the linker fail if someone
    starts to use it outside hibernate? Then we could leave it compiled out
    until then.

    Also it looks like riscv does not have ARCH_HIBERNATION_POSSIBLE so the
    new function added here couldn't be used yet. You could also just let
    the linker catch it if riscv ever enables hibernate?
    \
     
     \ /
      Last update: 2020-10-26 01:54    [W:4.078 / U:0.788 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site