Messages in this thread | | | From | Jernej Škrabec <> | Subject | Re: [PATCH 01/10] Revert "arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high" | Date | Sun, 25 Oct 2020 08:35:20 +0100 |
| |
Dne sobota, 24. oktober 2020 ob 18:25:06 CET je Chen-Yu Tsai napisal(a): > From: Chen-Yu Tsai <wens@csie.org> > > This reverts commit 75ee680cbd2e4d0156b94f9fec50076361ab12f2. > > Turns out the activity and link LEDs on the RJ45 port are active low, > just like on the Orange Pi PC. > > Revert the commit that says otherwise. > > Fixes: 75ee680cbd2e ("arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high") > Fixes: 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)") > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > If you have this board, please help test it. > > For me, the correct lighting of the LEDs is both LEDs should be lit > when connected at 100 Mbps.
Tested-by: Jernej Skrabec <jernej.skrabec@siol.net> Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Best regards, Jernej
| |