Messages in this thread | | | Date | Fri, 23 Oct 2020 15:31:21 -0700 | From | Eric Biggers <> | Subject | Re: [PATCH v3 4/5] crypto: lib/sha256 - Unroll SHA256 loop 8 times intead of 64 |
| |
On Fri, Oct 23, 2020 at 03:22:02PM -0400, Arvind Sankar wrote: > This reduces code size substantially (on x86_64 with gcc-10 the size of > sha256_update() goes from 7593 bytes to 1952 bytes including the new > SHA256_K array), and on x86 is slightly faster than the full unroll > (tested on Broadwell Xeon). > > Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
Looks good,
Reviewed-by: Eric Biggers <ebiggers@google.com>
| |