Messages in this thread | | | From | Dwaipayan Ray <> | Date | Sat, 24 Oct 2020 02:39:55 +0530 | Subject | Re: [PATCH RFC v2] checkpatch: extend attributes check to handle more patterns |
| |
On Sat, Oct 24, 2020 at 2:34 AM Joe Perches <joe@perches.com> wrote: > > On Sat, 2020-10-24 at 02:27 +0530, Dwaipayan Ray wrote: > > Also I tried the pattern attr =~ s/^_*(.*)_*$/$1/ > > for trimming the _ earlier. I think it doesn't trim the > > trailing underscores in the suffix as (.*) captures everything greedily. > > > > Is the iterative one perhaps okay instead? > > while($attr =~ s/(.*)_$/$1/) {} > > Then perhaps > > $curr_attr =~ s/^_+//; $curr_attr =~ s/_+$//; > Okay thanks! I will send in a new version when everything looks good and tested.
Regards, Dwaipayan.
| |