Messages in this thread | | | Date | Fri, 23 Oct 2020 18:52:45 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH v2] sched/fair: check for idle core |
| |
On Sat, 24 Oct 2020, Chen Yu wrote:
> On Fri, Oct 23, 2020 at 1:32 AM Julia Lawall <Julia.Lawall@inria.fr> wrote: > > > [cut] > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index aa4c6227cd6d..9b23dad883ee 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c > > @@ -5804,6 +5804,9 @@ wake_affine_idle(int this_cpu, int prev_cpu, int sync) > > if (sync && cpu_rq(this_cpu)->nr_running == 1) > > return this_cpu; > > > > + if (available_idle_cpu(prev_cpu)) > How about also taking sched_idle_cpu(prev_cpu) into consideration? > if (available_idle_cpu(prev_cpu) || sched_idle_cpu(prev_cpu))
I have no opinion about this, because it wasn't relevant to the application I was looking at. The available_idle check on prev previously in wake_affine_idle doesn't check sched_idle_cpu, so I didn't put it here.
julia
| |