Messages in this thread | | | Date | Fri, 23 Oct 2020 14:56:38 +0100 | From | Russell King - ARM Linux admin <> | Subject | Re: [PATCH v3] net: macb: add support for high speed interface |
| |
On Fri, Oct 23, 2020 at 01:34:09PM +0000, Parshuram Raju Thombare wrote: > >Whenever the interface changes, we go through the full reconfiguration > >procedure that I've already outlined. This involves calling the > >mac_prepare() method which calls into mvpp2_mac_prepare() and its > >child mvpp2__mac_prepare(). > > Ok, I misunderstood it as interface mode change between successive mac_prepare(). > If major reconfiguration is certain to happen after every interface mode change, > I will make another small modification in mac_prepare method to set appropriate > pcs_ops for selected interface mode. > pcs_ops for low speed, however, will just be existing non 10GBASE-R functions renamed. > This will allow us to get rid of old API's for non 10GBASE-R PCS. I hope you are ok with > these changes done in the same patch.
Yes, that sounds good.
Thanks.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |