Messages in this thread | | | From | Miguel Ojeda <> | Date | Fri, 23 Oct 2020 08:08:42 +0200 | Subject | Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo") |
| |
On Thu, Oct 22, 2020 at 4:36 AM Joe Perches <joe@perches.com> wrote: > > Use a more generic form for __section that requires quotes to avoid > complications with clang and gcc differences.
I performed visual inspection (one by one...) and the only thing I saw is that sometimes the `__attribute__` has a whitespace afterwards and sometimes it doesn't, same for the commas inside, e.g.:
- __used __attribute__((section(".modinfo"), unused, aligned(1))) \ + __used __section(".modinfo") __attribute__((unused, aligned(1))) \
and:
- __attribute__ ((unused,__section__ ("__param"),aligned(sizeof(void *)))) \ + __section("__param") __attribute__ ((unused, aligned(sizeof(void *)))) \
I think the patch tries to follow the style of the replaced line, but for the commas in this last case it didn't. Anyway, it is not important.
I can pick it up in my queue along with the __alias one and keep it for a few weeks in -next.
Cheers, Miguel
| |