lkml.org 
[lkml]   [2020]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset
    Hi Tony,

    I love your patch! Perhaps something to improve:

    [auto build test WARNING on s390/features]
    [also build test WARNING on linus/master kvms390/next linux/master v5.9 next-20201022]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch]

    url: https://github.com/0day-ci/linux/commits/Tony-Krowiak/s390-vfio-ap-dynamic-configuration-support/20201023-011543
    base: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
    config: s390-allyesconfig (attached as .config)
    compiler: s390-linux-gcc (GCC) 9.3.0
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # https://github.com/0day-ci/linux/commit/572c94c40a76754d49f07e4e383097d2db132f8c
    git remote add linux-review https://github.com/0day-ci/linux
    git fetch --no-tags linux-review Tony-Krowiak/s390-vfio-ap-dynamic-configuration-support/20201023-011543
    git checkout 572c94c40a76754d49f07e4e383097d2db132f8c
    # save the attached .config to linux build tree
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390

    If you fix the issue, kindly add following tag as appropriate
    Reported-by: kernel test robot <lkp@intel.com>

    All warnings (new ones prefixed by >>):

    >> drivers/s390/crypto/vfio_ap_ops.c:1119:5: warning: no previous prototype for 'vfio_ap_mdev_reset_queue' [-Wmissing-prototypes]
    1119 | int vfio_ap_mdev_reset_queue(unsigned int apid, unsigned int apqi,
    | ^~~~~~~~~~~~~~~~~~~~~~~~

    vim +/vfio_ap_mdev_reset_queue +1119 drivers/s390/crypto/vfio_ap_ops.c

    258287c994de8f Tony Krowiak 2018-09-25 1118
    ec89b55e3bce7c Pierre Morel 2019-05-21 @1119 int vfio_ap_mdev_reset_queue(unsigned int apid, unsigned int apqi,
    46a7263d4746a2 Tony Krowiak 2018-09-25 1120 unsigned int retry)
    46a7263d4746a2 Tony Krowiak 2018-09-25 1121 {
    46a7263d4746a2 Tony Krowiak 2018-09-25 1122 struct ap_queue_status status;
    ec89b55e3bce7c Pierre Morel 2019-05-21 1123 int retry2 = 2;
    ec89b55e3bce7c Pierre Morel 2019-05-21 1124 int apqn = AP_MKQID(apid, apqi);
    46a7263d4746a2 Tony Krowiak 2018-09-25 1125
    46a7263d4746a2 Tony Krowiak 2018-09-25 1126 do {
    ec89b55e3bce7c Pierre Morel 2019-05-21 1127 status = ap_zapq(apqn);
    46a7263d4746a2 Tony Krowiak 2018-09-25 1128 switch (status.response_code) {
    46a7263d4746a2 Tony Krowiak 2018-09-25 1129 case AP_RESPONSE_NORMAL:
    ec89b55e3bce7c Pierre Morel 2019-05-21 1130 while (!status.queue_empty && retry2--) {
    ec89b55e3bce7c Pierre Morel 2019-05-21 1131 msleep(20);
    ec89b55e3bce7c Pierre Morel 2019-05-21 1132 status = ap_tapq(apqn, NULL);
    ec89b55e3bce7c Pierre Morel 2019-05-21 1133 }
    024cdcdbf3cf99 Halil Pasic 2019-09-03 1134 WARN_ON_ONCE(retry2 <= 0);
    46a7263d4746a2 Tony Krowiak 2018-09-25 1135 return 0;
    46a7263d4746a2 Tony Krowiak 2018-09-25 1136 case AP_RESPONSE_RESET_IN_PROGRESS:
    46a7263d4746a2 Tony Krowiak 2018-09-25 1137 case AP_RESPONSE_BUSY:
    46a7263d4746a2 Tony Krowiak 2018-09-25 1138 msleep(20);
    46a7263d4746a2 Tony Krowiak 2018-09-25 1139 break;
    46a7263d4746a2 Tony Krowiak 2018-09-25 1140 default:
    46a7263d4746a2 Tony Krowiak 2018-09-25 1141 /* things are really broken, give up */
    46a7263d4746a2 Tony Krowiak 2018-09-25 1142 return -EIO;
    46a7263d4746a2 Tony Krowiak 2018-09-25 1143 }
    46a7263d4746a2 Tony Krowiak 2018-09-25 1144 } while (retry--);
    46a7263d4746a2 Tony Krowiak 2018-09-25 1145
    46a7263d4746a2 Tony Krowiak 2018-09-25 1146 return -EBUSY;
    46a7263d4746a2 Tony Krowiak 2018-09-25 1147 }
    46a7263d4746a2 Tony Krowiak 2018-09-25 1148

    ---
    0-DAY CI Kernel Test Service, Intel Corporation
    https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
    [unhandled content-type:application/gzip]
    \
     
     \ /
      Last update: 2020-10-22 21:47    [W:4.396 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site