lkml.org 
[lkml]   [2020]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net RFC] net: Clear IFF_TX_SKB_SHARING for all Ethernet devices using skb_padto
On Thu, 22 Oct 2020 00:46:38 -0700 Xie He wrote:
> It was very hard for me to attempt fixing. There are too many drivers
> that need to be fixed. Fixing them is very time-consuming and may also
> be error-prone. So I think it may be better to just remove
> IFF_TX_SKB_SHARING from ether_setup. Drivers that support this feature
> should add this flag by themselves. This also makes our code cleaner.

Are most of these drivers using skb_padto()? Is that the reason they
can't be sharing the SKB?

I think the IFF_TX_SKB_SHARING flag is only used by pktgen, so perhaps
we can make sure pktgen doesn't generate skbs < dev->min_mtu, and then
the drivers won't pad?

\
 
 \ /
  Last update: 2020-10-22 17:23    [W:1.854 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site