Messages in this thread | | | From | Daniel Gutson <> | Date | Thu, 22 Oct 2020 09:08:13 -0300 | Subject | Re: [PATCH 2/2] Platform integrity information in sysfs (version 9) |
| |
On Sun, Oct 4, 2020 at 1:01 AM Randy Dunlap <rdunlap@infradead.org> wrote: > > On 9/30/20 9:37 AM, Daniel Gutson wrote: > > diff --git a/drivers/mtd/spi-nor/controllers/Kconfig b/drivers/mtd/spi-nor/controllers/Kconfig > > index 5c0e0ec2e6d1..e7eaef506fc2 100644 > > --- a/drivers/mtd/spi-nor/controllers/Kconfig > > +++ b/drivers/mtd/spi-nor/controllers/Kconfig > > @@ -29,6 +29,7 @@ config SPI_NXP_SPIFI > > > > config SPI_INTEL_SPI > > tristate > > + depends on PLATFORM_INTEGRITY_DATA > > So SPI_INTEL_SPI_PCI selects SPI_INTEL_SPI: > > config SPI_INTEL_SPI_PCI > tristate "Intel PCH/PCU SPI flash PCI driver (DANGEROUS)" > depends on X86 && PCI > select SPI_INTEL_SPI > > without checking that PLATFORM_INTEGRITY_DATA is set/enabled. > > "select" does not follow any kconfig dependency chains, so when > PLATFORM_INTEGRITY_DATA is not enabled, this should be causing > a kconfig warning, which is not OK.
Since now SPI_INTEL_SPI_PCI can be enabled without PLATFORM_INTEGRITY_DATA (thanks to the #ifdefs), I think I'll just remove the 'depends' and will leave this as it was.
> > > -- > ~Randy >
--
Daniel Gutson Engineering Director Eclypsium, Inc.
Below The Surface: Get the latest threat research and insights on firmware and supply chain threats from the research team at Eclypsium. https://eclypsium.com/research/#threatreport
| |