Messages in this thread | | | Subject | Re: [PATCH v7 3/4] docs: Add documentation for userspace client interface | From | Jeffrey Hugo <> | Date | Wed, 21 Oct 2020 21:04:50 -0600 |
| |
On 10/21/2020 11:46 AM, Hemant Kumar wrote: > Hi Jeff, > > On 10/21/20 8:28 AM, Jeffrey Hugo wrote: >> On 10/16/2020 10:04 PM, Hemant Kumar wrote: >>> +release >> >> Should this be "close" since close() is the actual function userspace >> would call? > I was keeping kernel driver in mind while writing this, i can change it > to close() if release() is confusing here.
I guess I was considering the client perspective, but this is kernel documentation so I can see your perspective. I don't have a strong preference. I suppose keep it as is.
>> >>> +------- >>> + >>> +Decrements UCI device reference count and UCI channel reference >>> count upon last >>> +release(). UCI channel clean up is performed. MHI channel moves to >>> disabled >>> +state and inbound buffers are freed. >>> + >> >> > Thanks, > Hemant
-- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |