Messages in this thread |  | | Subject | Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it | | From | Randy Dunlap <> | | Date | Wed, 21 Oct 2020 14:30:53 -0700 |
| |
On 10/21/20 2:29 PM, David Gow wrote: > On Thu, Oct 22, 2020 at 5:15 AM Brendan Higgins > <brendanhiggins@google.com> wrote: >> >> On Tue, Oct 20, 2020 at 12:37 AM Geert Uytterhoeven >> <geert@linux-m68k.org> wrote: >>> >>> EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the >>> user may not want to enable. Fix this by making the test depend on >>> EXT4_FS instead. >>> >>> Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps") >>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> >> >> If I remember correctly, having EXT4_KUNIT_TESTS select EXT4_FS was >> something that Ted specifically requested, but I don't have any strong >> feelings on it either way. > > For what it's worth, the upcoming FAT filesystem tests[1] are also > select-ing FAT_FS at the moment, so if this changes here, I'll likely > update it there as well. > > -- David > > [1]: https://lore.kernel.org/linux-kselftest/20201021061713.1545931-1-davidgow@google.com/T/#u >
then hopefully both get updated. This is just backwards.
-- ~Randy
|  |