lkml.org 
[lkml]   [2020]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] thermal: replace spin_lock_irqsave by spin_lock in hard IRQ
Hi Tian,

Thanks for your work.

On 2020-10-21 11:05:30 +0800, Tian Tao wrote:
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
> drivers/thermal/rcar_thermal.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index 5c2a13b..6ae757d 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -409,16 +409,15 @@ static irqreturn_t rcar_thermal_irq(int irq, void *data)
> {
> struct rcar_thermal_common *common = data;
> struct rcar_thermal_priv *priv;
> - unsigned long flags;
> u32 status, mask;
>
> - spin_lock_irqsave(&common->lock, flags);
> + spin_lock(&common->lock);
>
> mask = rcar_thermal_common_read(common, INTMSK);
> status = rcar_thermal_common_read(common, STR);
> rcar_thermal_common_write(common, STR, 0x000F0F0F & mask);
>
> - spin_unlock_irqrestore(&common->lock, flags);
> + spin_unlock(&common->lock);
>
> status = status & ~mask;
>
> --
> 2.7.4
>

--
Regards,
Niklas Söderlund

\
 
 \ /
  Last update: 2020-10-21 21:44    [W:0.091 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site