Messages in this thread | | | Date | Wed, 21 Oct 2020 16:08:52 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH 2/2] net: phy: adin: implement cable-test support |
| |
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Hi Alexandru
Overall, this looks good.
> +static int adin_cable_test_report_trans(int result) > +{ > + int mask; > + > + if (result & ADIN1300_CDIAG_RSLT_GOOD) > + return ETHTOOL_A_CABLE_RESULT_CODE_OK; > + if (result & ADIN1300_CDIAG_RSLT_OPEN) > + return ETHTOOL_A_CABLE_RESULT_CODE_OPEN; > + > + /* short with other pairs */ > + mask = ADIN1300_CDIAG_RSLT_XSHRT3 | > + ADIN1300_CDIAG_RSLT_XSHRT2 | > + ADIN1300_CDIAG_RSLT_XSHRT1; > + if (result & mask) > + return ETHTOOL_A_CABLE_RESULT_CODE_CROSS_SHORT;
The nice thing about the netlink API is that it is extendable without breaking backwards compatibility. You could if you want add another attribute, indicating what pair it is shorted to.
Andrew
| |