lkml.org 
[lkml]   [2020]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible
On Wed, Oct 21, 2020 at 12:39 PM Joel Stanley <joel@jms.id.au> wrote:

>
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index 331d4bdd4a67..15cdfeb135b0 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -653,6 +653,11 @@ static bool ftgmac100_tx_complete_packet(struct ftgmac100 *priv)
> ftgmac100_free_tx_packet(priv, pointer, skb, txdes, ctl_stat);
> txdes->txdes0 = cpu_to_le32(ctl_stat & priv->txdes0_edotr_mask);
>
> + /* Ensure the descriptor config is visible before setting the tx
> + * pointer.
> + */
> + smp_wmb();
> +
> priv->tx_clean_pointer = ftgmac100_next_tx_pointer(priv, pointer);
>
> return true;
> @@ -806,6 +811,11 @@ static netdev_tx_t ftgmac100_hard_start_xmit(struct sk_buff *skb,
> dma_wmb();
> first->txdes0 = cpu_to_le32(f_ctl_stat);
>
> + /* Ensure the descriptor config is visible before setting the tx
> + * pointer.
> + */
> + smp_wmb();
> +

Shouldn't these be paired with smp_rmb() on the reader side?

Arnd

\
 
 \ /
  Last update: 2020-10-21 14:41    [W:0.141 / U:3.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site