lkml.org 
[lkml]   [2020]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v17 4/4] overlayfs: inode_owner_or_capable called during execv
    Date
    Using old_creds as an indication that we are not overriding the
    credentials, bypass call to inode_owner_or_capable. This solves
    a problem with all execv calls being blocked when using the caller's
    credentials.

    Signed-off-by: John Stultz <john.stultz@linaro.org>
    Signed-off-by: Mark Salyzyn <salyzyn@android.com>
    Fixes: 05acefb4872da ("ovl: check permission to open real file")
    To: linux-fsdevel@vger.kernel.org
    To: linux-unionfs@vger.kernel.org
    Cc: Stephen Smalley <sds@tycho.nsa.gov>
    Cc: linux-kernel@vger.kernel.org
    Cc: linux-security-module@vger.kernel.org
    Cc: kernel-team@android.com

    v17 - rebase

    v16 - introduced fix over rebased series
    ---
    fs/overlayfs/file.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
    index b1357bb067d9..9ab9663b02d8 100644
    --- a/fs/overlayfs/file.c
    +++ b/fs/overlayfs/file.c
    @@ -53,7 +53,7 @@ static struct file *ovl_open_realfile(const struct file *file,
    err = inode_permission(realinode, MAY_OPEN | acc_mode);
    if (err) {
    realfile = ERR_PTR(err);
    - } else if (!inode_owner_or_capable(realinode)) {
    + } else if (old_cred && !inode_owner_or_capable(realinode)) {
    realfile = ERR_PTR(-EPERM);
    } else {
    realfile = open_with_fake_path(&file->f_path, flags, realinode,
    --
    2.29.0.rc1.297.gfa9743e501-goog
    \
     
     \ /
      Last update: 2020-10-20 21:18    [W:2.337 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site