lkml.org 
[lkml]   [2020]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] drm/msm: kthread_worker conversion
On Mon, Oct 19, 2020 at 02:10:50PM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> In particular, converting the async atomic commit (for cursor updates,
> etc) to SCHED_FIFO kthread_worker helps with some cases where we
> wouldn't manage to flush the updates within the 1ms-before-vblank
> deadline resulting in fps drops when there is cursor movement.
>
> Rob Clark (3):
> drm/msm/gpu: Convert retire/recover work to kthread_worker
> drm/msm/kms: Update msm_kms_init/destroy
> drm/msm/atomic: Convert to per-CRTC kthread_work

So i915 has it's own commit worker already for $reasons, but I don't think
that's a good path to go down with more drivers. And the problem seems
entirely generic in nature ...
-Daniel

>
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 3 +--
> drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 6 ++---
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 4 +--
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 +--
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 +++++-
> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 8 +++++-
> drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 11 ++++++---
> drivers/gpu/drm/msm/disp/mdp_kms.h | 9 +++++--
> drivers/gpu/drm/msm/msm_atomic.c | 25 +++++++++++++++----
> drivers/gpu/drm/msm/msm_drv.h | 3 ++-
> drivers/gpu/drm/msm/msm_gpu.c | 30 +++++++++++++++--------
> drivers/gpu/drm/msm/msm_gpu.h | 13 +++++++---
> drivers/gpu/drm/msm/msm_kms.h | 23 ++++++++++++++---
> 13 files changed, 104 insertions(+), 43 deletions(-)
>
> --
> 2.26.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

\
 
 \ /
  Last update: 2020-10-20 10:25    [W:0.102 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site