Messages in this thread | | | From | Thara Gopinath <> | Subject | Re: [PATCH 10/11] [DEBUG] firmware: arm_scmi: add custom_dummy SCMI devname | Date | Tue, 20 Oct 2020 22:49:23 -0400 |
| |
On 10/14/20 11:05 AM, Cristian Marussi wrote: > Add custom_dummy SCMI devname. > > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> > --- > drivers/firmware/arm_scmi/driver.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 55df134c2338..5c39a738866a 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -993,6 +993,7 @@ static struct scmi_prot_devnames devnames[] = { > { SCMI_PROTOCOL_CLOCK, { "clocks" },}, > { SCMI_PROTOCOL_SENSOR, { "hwmon" },}, > { SCMI_PROTOCOL_RESET, { "reset" },}, > + { SCMI_PROTOCOL_CUSTOM_DUMMY, { "custom_dummy" },},
Hi Cristian,
Thanks for the sample dummy custom protocol and driver! The problem with adding scmi devname into the array is that every time a custom vendor protocol is added, the array has to be extended. Instead since the scmi spec supports the range 0x80-0xff for custom protocols, why not check for that range in scmi_create_protocol_devices and go ahead with registering the creating the protocol device via scmi_create_protocol_device?
> }; > > static inline void >
-- Warm Regards Thara
| |