lkml.org 
[lkml]   [2020]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces
On Fri,  2 Oct 2020 13:40:01 -0400
Jarod Wilson <jarod@redhat.com> wrote:

> By default, enable retaining all user-facing API that includes the use of
> master and slave, but add a Kconfig knob that allows those that wish to
> remove it entirely do so in one shot.
>
> Cc: Jay Vosburgh <j.vosburgh@gmail.com>
> Cc: Veaceslav Falico <vfalico@gmail.com>
> Cc: Andy Gospodarek <andy@greyhouse.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Thomas Davis <tadavis@lbl.gov>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
> ---
> drivers/net/Kconfig | 12 ++++++++++++
> drivers/net/bonding/bond_main.c | 4 ++--
> drivers/net/bonding/bond_options.c | 4 ++--
> drivers/net/bonding/bond_procfs.c | 8 ++++++++
> drivers/net/bonding/bond_sysfs.c | 14 ++++++++++----
> drivers/net/bonding/bond_sysfs_port.c | 6 ++++--
> 6 files changed, 38 insertions(+), 10 deletions(-)
>

This is problematic. You are printing both old and new values.
Also every distribution will have to enable it.

This looks like too much of change to users.

\
 
 \ /
  Last update: 2020-10-02 21:14    [W:0.104 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site