Messages in this thread | | | Date | Fri, 2 Oct 2020 08:01:34 +0100 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: kempld-core: Mark kempld-acpi_table as __maybe_unused |
| |
On Thu, 01 Oct 2020, Michael Brunner wrote:
> The Intel 0-DAY CI Kernel Test Service reports an unused variable > warning when compiling with clang for PowerPC: > > >> drivers/mfd/kempld-core.c:556:36: warning: unused variable 'kempld_acpi_table' [-Wunused-const-variable] > static const struct acpi_device_id kempld_acpi_table[] = { > > The issue can be fixed by marking kempld_acpi_table as __maybe_unused. > > Fixes: e8299c7313af ("[PATCH] mfd: Add ACPI support to Kontron PLD driver") > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Michael Brunner <michael.brunner@kontron.com> > --- > drivers/mfd/kempld-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c > index 1dfe556df038..273481dfaad4 100644 > --- a/drivers/mfd/kempld-core.c > +++ b/drivers/mfd/kempld-core.c > @@ -553,7 +553,7 @@ static int kempld_remove(struct platform_device *pdev) > return 0; > } > > -static const struct acpi_device_id kempld_acpi_table[] = { > +static const struct acpi_device_id __maybe_unused kempld_acpi_table[] = { > { "KEM0001", (kernel_ulong_t)&kempld_platform_data_generic }, > {} > };
This is not the right fix. Better just to compile it out completely in these circumstances. I already have a fix for this in soak.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |