Messages in this thread | | | Date | Fri, 2 Oct 2020 13:24:44 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 00/21] spi: dw: Add full Baikal-T1 SPI Controllers support |
| |
On Fri, Oct 02, 2020 at 01:28:08AM +0300, Serge Semin wrote: > Originally I intended to merge a dedicated Baikal-T1 System Boot SPI > Controller driver into the kernel and leave the DW APB SSI driver > untouched. But after a long discussion (see the link at the bottom of the > letter) Mark and Andy persuaded me to integrate what we developed there > into the DW APB SSI core driver to be useful for another controllers, > which may have got the same peculiarities/problems as ours: > - No IRQ. > - No DMA. > - No GPIO CS, so a native CS is utilized. > - small Tx/Rx FIFO depth. > - Automatic CS assertion/de-assertion. > - Slow system bus. > All of them have been fixed in the framework of this patchset in some > extent at least for the SPI memory operations. As I expected it wasn't > that easy and the integration took that many patches as you can see from > the subject. Though some of them are mere cleanups or weakly related with > the subject fixes, but we just couldn't leave the code as is at some > places since we were working with the DW APB SSI driver anyway. Here is > what we did to fix the original DW APB SSI driver, to make it less messy.
Maybe it's time to put your name into MAINTAINERS for this driver?
-- With Best Regards, Andy Shevchenko
| |