Messages in this thread | | | Subject | Re: [PATCH] usb: cdns3: platform_get_irq_byname_optional instead platform_get_irq_byname | From | Roger Quadros <> | Date | Fri, 2 Oct 2020 11:53:57 +0300 |
| |
Pawel,
On 30/09/2020 09:57, Pawel Laszczak wrote: > To avoid duplicate error information patch replaces platform_get_irq_byname > into platform_get_irq_byname_optional.
What is duplicate error information?
> > A change was suggested during reviewing CDNSP driver by Chunfeng Yun. > > Signed-off-by: Pawel Laszczak <pawell@cadence.com> > --- > drivers/usb/cdns3/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c > index a0f73d4711ae..a3f6dc44cf3a 100644 > --- a/drivers/usb/cdns3/core.c > +++ b/drivers/usb/cdns3/core.c > @@ -465,7 +465,7 @@ static int cdns3_probe(struct platform_device *pdev) > > cdns->xhci_res[1] = *res; > > - cdns->dev_irq = platform_get_irq_byname(pdev, "peripheral"); > + cdns->dev_irq = platform_get_irq_byname_optional(pdev, "peripheral");
As per DT binding document, these are mandatory properties
- interrupts: Interrupts used by cdns3 controller: "host" - interrupt used by XHCI driver. "peripheral" - interrupt used by device driver "otg" - interrupt used by DRD/OTG part of driver
for dr_mode == "otg" -> all 3 are mandatory. for dr_mode == "host" -> "otg" and "peripheral" IRQs are not required. for dr_mode == "periphearal" -> "otg" and "host" IRQs are not required.
> if (cdns->dev_irq == -EPROBE_DEFER) > return cdns->dev_irq; > > @@ -477,7 +477,7 @@ static int cdns3_probe(struct platform_device *pdev) > return PTR_ERR(regs); > cdns->dev_regs = regs; > > - cdns->otg_irq = platform_get_irq_byname(pdev, "otg"); > + cdns->otg_irq = platform_get_irq_byname_optional(pdev, "otg"); > if (cdns->otg_irq == -EPROBE_DEFER) > return cdns->otg_irq; > >
cheers, -roger -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
| |